Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GCP KMS Signer #8096

Merged
merged 7 commits into from
Jun 7, 2024
Merged

Support GCP KMS Signer #8096

merged 7 commits into from
Jun 7, 2024

Conversation

moricho
Copy link
Contributor

@moricho moricho commented Jun 7, 2024 •
edited
Loading

Motivation

Closes: #8095

Solution

With specifying GCP_PROJECT_ID, GCP_LOCATION, GCP_KEYRING, GCP_KEY_NAME, GCP_KEY_VERSION env variables, you can sign with Google Cloud KMS by enabling --gcp flag

@moricho moricho changed the title Gcp kms signer Support GCP KMS Signer Jun 7, 2024
@moricho moricho marked this pull request as draft June 7, 2024 01:42
@moricho moricho marked this pull request as ready for review June 7, 2024 07:31
DaniPopes
DaniPopes approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This duplicates a lot of dependencies due to tonic and others, but I think this is ok since it's optional.

@DaniPopes DaniPopes merged commit a09713b into foundry-rs:master Jun 7, 2024
20 checks passed
@grandizzy
Copy link
Collaborator

I think would be nice to have the gcp option in cast wallet list as well

foundry/crates/cast/bin/cmd/wallet/list.rs

Lines 24 to 26 in a09713b

/// List accounts from AWS KMS.
#[arg(long, hide = !cfg!(feature = "aws-kms"))]
aws: bool,

@moricho moricho deleted the gcp-kms-signer branch June 11, 2024 07:06
@moricho moricho mentioned this pull request Jun 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@Evalir Evalir Awaiting requested review from Evalir

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Google Cloud KMS Signer
3 participants
@moricho @grandizzy @DaniPopes