perf: new-type TargetedContracts #8180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
dani/name-targeted-contracts
branch
from
979215c to
25d07df
Compare
DaniPopes
force-pushed
the
dani/name-targeted-contracts
branch
from
25d07df to
9d7d2ed
Compare
grandizzy
force-pushed
the
dani/name-targeted-contracts
branch
from
7c4b6cf to
ff32894
Compare
grandizzy
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
looks great, I pushed a commit to fix seed test. with the newly introduced TargetedContract we can now easily support #4352 by adding an add_excluded_selectors function that would push to pub excluded_functions: Vec<Function>, which will be removed when calling abi_fuzzed_functions, going to make a PR for such
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some methods to a TargetedContracts new-type to be able to borrow from it nicely
To avoid collecting
fuzzed_functionsI re-added proptestSelectorininvariant_strat, should still be OK, PTAL @grandizzy