feat(cheatcodes): implement EIP-2098 in vm.sign
#8538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leovct
requested review from
DaniPopes,
mattsse,
klkvr and
Evalir
as code owners
DaniPopes
requested changes
Jul 28, 2024
DaniPopes
requested changes
Jul 29, 2024
benwjhack
pushed a commit
to CompassLabs/foundry-test
that referenced
this pull request
Sep 11, 2024
* feat: implement EIP-2098 in vm.sign * fix: clippy * test: fix * fix: forge-fmt * chore: implement new cheatcode vm.signEIP2098 * fix: typos * fix: another typo * fix * test: update sign tests * fix: typo * chore: rename `vm.signEIP2098()` into `vm.signCompact()` * chore: update `encode_compact_signature` impl * chore: update `signCompact` tests * chore: factorize * chore: rename fns * chore: nit * fix: issue * chore: nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #6606
This PR implements EIP-2098 in a new cheatcode called
vm.signEIP2098, introducing a compact signature representation that reduces the signature size from 65 to 64 bytes. The function returns a tuple(r, vs)wherevsencodes both the signature'ssvalue and the recovery idvin a single bytes32, allowing for more efficient signature handling and storage.Solution
x