-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vm.publicKeyP256
#8679
Merged
Merged
feat: vm.publicKeyP256
#8679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested changes
Aug 15, 2024
mattsse
reviewed
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, pending doc nit
DaniPopes
approved these changes
Aug 15, 2024
Co-authored-by: protocolwhisper <chrismata10@gmail.com>
Can you please add the function to the |
pcaversaccio
added a commit
to pcaversaccio/snekmate
that referenced
this pull request
Aug 27, 2024
### 🕓 Changelog The Foundry PR [#8679](foundry-rs/foundry#8679) and `forge-std` PR [#596](foundry-rs/forge-std#596) introduced a native `publicKey256` cheat code to derive the public key coordinates based on the `secp256r1` curve from a random `uint256` private key. As a result, I refactor the `p256` test and remove the now redundant [`FreshCryptoLib`](https://github.com/rdubois-crypto/FreshCryptoLib) submodule from the codebase. --------- Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
benwjhack
pushed a commit
to CompassLabs/foundry-test
that referenced
this pull request
Sep 11, 2024
* publicKeyP256 * clippy * fix error * update doc * update error message * add coauthor Co-authored-by: protocolwhisper <chrismata10@gmail.com> --------- Co-authored-by: protocolwhisper <chrismata10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #7908
Adds cheatcode for deriving public key for P256 private key
Solution