Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cheatcodes): ArbitraryStorage as option #8848

Merged
merged 7 commits into from
Sep 13, 2024
Merged

chore(cheatcodes): ArbitraryStorage as option #8848

merged 7 commits into from
Sep 13, 2024

Conversation

grandizzy
Copy link
Collaborator

Motivation

re #8807 (comment)

Solution

@grandizzy
Copy link
Collaborator Author

@DaniPopes would making ArbitraryStorage as an Option and check if some in step_end be better than checking the op::SLOAD? pls check, thank you

@grandizzy grandizzy mentioned this pull request Sep 12, 2024
Merged
@DaniPopes
Copy link
Member

Yeah that makes sense

@grandizzy grandizzy marked this pull request as ready for review September 12, 2024 18:45
DaniPopes
DaniPopes requested changes Sep 12, 2024
View reviewed changes
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
crates/cheatcodes/src/utils.rs Outdated Show resolved Hide resolved
@grandizzy grandizzy enabled auto-merge (squash) September 13, 2024 05:44
@grandizzy grandizzy merged commit 19bd60a into foundry-rs:master Sep 13, 2024
20 checks passed
rplusq pushed a commit to rplusq/foundry that referenced this pull request Sep 25, 2024
@grandizzy @DaniPopes @rplusq
chore(cheatcodes): ArbitraryStorage as option (foundry-rs#8848)
b5ca9f2 
* chore(cheatcodes): ArbitraryStorage as option

* Update crates/cheatcodes/src/utils.rs

Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>

* Update crates/cheatcodes/src/inspector.rs

Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>

* Early arbitrary_storage_end return

---------

Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grandizzy @DaniPopes