fix(anvil): handle OP deposit txs in TypedTransaction and PoolTransaction conversion
#8942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
klkvr and
mattsse
as code owners
mattsse
approved these changes
Sep 24, 2024
|
unrelated error |
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Sep 25, 2024
…ansaction` conversion (foundry-rs#8942) * fix(`anvil`): handle OP deposit tx in TypeTransaction conversion. * nits * clippy * test Co-authored-by: grandizzy <38490174+grandizzy@users.noreply.github.com> * nits --------- Co-authored-by: grandizzy <38490174+grandizzy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #8940
Solution
Change
TryFromimplementations ofPoolTransactionandTypedTransactionto useWithOtherFields<RpcTransaction>instead ofRpcTransaction