fix(forge): warn if script is executed with cbor metadata disabled #9005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
DaniPopes
requested changes
Oct 2, 2024
| @@ -211,6 +211,10 @@ impl ScriptArgs { | |||
|
|
|||
| let (config, mut evm_opts) = self.load_config_and_evm_opts_emit_warnings()?; | |||
|
|
|||
| // print warning message if `cbor_metadata` is disabled | |||
| let msg = "Warning! \"--no-metadata\" flag or \"cbor_metadata\" set to false can result in deployment failures.".yellow(); | |||
| p_println!(!config.cbor_metadata => "{msg}"); | |||
There was a problem hiding this comment.
👍 noted, thank you (I used the coverage warn style, but will update that one to cli warn as well), reworking the whole PR a little bit so changed to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #8995
Added warn message inline with coverage warn if cbor metadata disabled when using forge script
Solution