feat(cheatcodes): implement new cheatcode to check if a string contains another string

[leovct]

Motivation

Closes #4859

Solution

Simple check if a string contains another string.

As a follow-up, we could implement other cheatcodes to check if an array contains an element?

[mattsse]

I just realized that we don't even have vm.contains
so this would just by assert(vm.contains())

wdyt @grandizzy

[grandizzy]

I just realized that we don't even have vm.contains so this would just by assert(vm.contains())

wdyt @grandizzy

yep, agree vm.contains to return bool would be better as could have further usages in test (execute conditional branches)

[zerosnacks]

Thanks! LGTM

Personally don't have a strong preference for renaming assertContains -> contains as proposed by others but wouldn't mind it either. Without the assert* prefix would be more clear to users that they can use it in branches and it doesn't throw a hard error that they might expect when using assertions.

[leovct]

Thanks! LGTM

Personally don't have a strong preference for renaming assertContains -> contains as proposed by others but wouldn't mind it either. Without the assert* prefix would be more clear to users that they can use it in branches and it doesn't throw a hard error that they might expect when using assertions.

Sure, let me rename the method from assertContains to contains, as this makes more sense to align with the standard.

[leovct]

@zerosnacks PR is ready for another review :)

[grandizzy]

Lgtm!

[zerosnacks]

Thanks @leovct! LGTM

[johnnyshankman]

@zerosnacks @leovct @grandizzy thank you so much for getting this over the line and closing out my older PR! Cheers!