Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support EIP-7702 Delegations in Forge #9236
Support EIP-7702 Delegations in Forge #9236
Changes from 9 commits
2467a3f
b16edd8
a286c7d
a6de137
619aa1e
d5ae337
05cdad8
1d8f42e
c819383
da62cc8
bad6230
b3666aa
376a092
93963ee
df33332
912ce6d
e97e185
40fd5f1
bdef83c
e4082b1
f18a0e8
d8ea3ec
0bd6f42
8f480fe
25aeea7
4310c2d
bdc0b78
c10be3e
7090999
af7e39c
4394065
aa0ece7
a833dd6
f432430
6d46417
d79f376
edbaf4c
c050393
cdfe503
475216d
d0ad8bd
113854c
0a93989
74302de
de9dea4
d560464
2a30b42
713bd64
89cd62d
7df7dcb
5151459
1c6e7d0
ff2801c
002221a
e829b6e
d2d2376
8fa8e64
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe delegations would be attached to separate transactions vs broadcast blocks, so it would be something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the comment! looking at this closer - since 7702 makes the EOA itself the target of the tx, i think we need to route all calls through the EOA first.
right now we can do this with a raw call:
but for better UX, maybe we could either:
vm.delegatedCall(alice, implementation.execute, calls);
what do you think would be more ergonomic for users?