Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forge): inline config for tests #9342

Closed
wants to merge 13 commits into from
Closed

feat(forge): inline config for tests #9342

wants to merge 13 commits into from

Conversation

yash-atreya
Copy link
Member

@yash-atreya yash-atreya commented Nov 18, 2024 •
edited
Loading

Motivation

Closes #8564 + Closes #6908

Solution

  • Introduces TestConfig to TestOptions.
  • TestConfig implements InlineConfigParser and parses inline with the key test. e.g forge-config: default.test.evm-version: shanghai
  • Sets the TestConfig per test in ContractRunner.prepare_test.
  • Important to note that this would override any config passed via CLI or foundry.toml

TODO

  • Apply TestConfig to invariants
  • Add isolate config.
  • Tests

@yash-atreya yash-atreya self-assigned this Nov 18, 2024
@grandizzy
Copy link
Collaborator

related #6228

@yash-atreya yash-atreya marked this pull request as ready for review November 19, 2024 18:55
@yash-atreya
Copy link
Member Author

Superseded by #9414

@yash-atreya yash-atreya removed their assignment Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: allow evm_version config to be defined inline feat: allow isolate config to be defined inline
2 participants
@yash-atreya @grandizzy