Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update incorrect documentation in the READ.me #9538

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

jtfirek
Copy link
Contributor

@jtfirek jtfirek commented Dec 11, 2024

Motivation

I think this comment is incorrect. Based off my reading of this solidity page, it seems that this flag prevents the appending of the CBOR encoded file to the bytecode

Solution

changing the comment

@onbjerg onbjerg enabled auto-merge (squash) December 11, 2024 18:57
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks!

@onbjerg onbjerg merged commit c4fcf12 into foundry-rs:master Dec 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants