Implement thoughtsense and apply to Empathic Sense ancestry feature #15115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonward
reviewed
Jun 17, 2024
|
I think we'd want a distinct visual effect for this so it can be identified to a user. |
|
Updates change the colour to green. |
|
Cauthooj creature wrongly had tremorsense when it should have thoughtsense. |
stwlam
requested changes
Jul 4, 2024
|
You might consider rebasing in the future instead of merging master on top. |
stwlam
reviewed
Jul 4, 2024
Remove walls: false from senseThoughts Co-authored-by: Shark that walks like a man <106829671+stwlam@users.noreply.github.com>
simplify isOfType check for senseThoughts Co-authored-by: Shark that walks like a man <106829671+stwlam@users.noreply.github.com>
Remove conditional field access for mindless Co-authored-by: Shark that walks like a man <106829671+stwlam@users.noreply.github.com>
change thsense to thoughtsense Co-authored-by: Shark that walks like a man <106829671+stwlam@users.noreply.github.com>
Remove walls: false from senseThoughts Co-authored-by: Shark that walks like a man <106829671+stwlam@users.noreply.github.com>
simplify isOfType check for senseThoughts Co-authored-by: Shark that walks like a man <106829671+stwlam@users.noreply.github.com>
Remove conditional field access for mindless Co-authored-by: Shark that walks like a man <106829671+stwlam@users.noreply.github.com>
change thsense to thoughtsense Co-authored-by: Shark that walks like a man <106829671+stwlam@users.noreply.github.com>
farling42
commented
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation suggested by #15111
It also updates the "Empathic Sense" ancestry feature for the Kashrishi race to use this new sense out to 15 ft (even behind walls).
The new sense will only detect Actor types of: character, npc, familiar.
It is best tested by giving the PC with "Empathic Sense" the "Deaf" condition (otherwise they can hear it).
This can also be applied to the Cauthooj (in Monster Core) - "The cauthooj senses all non-mindless creatures at the listed range."
Note that Rhu-Chalik (in Monster Core) have this as a precise sense.