feat: Allow theme-build command to fail gracefully #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laura-johnson
approved these changes
Sep 16, 2024
|
Thanks Callin! |
fkbender
pushed a commit
that referenced
this pull request
Sep 16, 2024
# [6.2.0](6.1.0...6.2.0) (2024-09-16) ### Features * check if src or components directory exists before compiling theme assets ([#115](#115)) ([41f4cc7](41f4cc7))
|
🎉 This PR is included in version 6.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
During the initial project setup it's typical to also setup the CI process. This process triggers the
npm run theme-buildcommand for remote environments. However, the project doesn't yet have a component library installed so any theme-build attempts cause a failure.Functional Testing:
composer create-project fourkitchens/sous-drupal-project theme-build-test- choose any setup optioncd theme-build-test && nvm use && npm run theme-build- verify this failscomposer create-project fourkitchens/sous-drupal-project:dev-feat-theme-build-fail-graceful theme-build-test-2cd theme-build-test-2 && nvm use && npm run theme-build- verify this skips the build step with a message.