Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to 'unstick' headers #9

Closed
wants to merge 1 commit into from

Conversation

joshfisher
Copy link

Adding convenience method for retrieving the bounding box for a given section

Adding convenience method for retrieving the bounding box for a given section
@adamalix
Copy link

@csmulhern @bdorfman we're using this change internally, not sure if you find it useful.

@bdorfman
Copy link
Contributor

Yeah having an ability to unstick headers is good, we probably should have shipped with one. Thanks.

What are you using the section rect for exactly? I'm about to merge another fix that changes all section rects to be full-width to get around some header issues, not sure if that will mess you up.

bdorfman pushed a commit that referenced this pull request Apr 13, 2015
Add ability to have non-pinned headers.

Also adds contentFrameForSection: and other documentation cleanup.

Refactors and resolves conflicts in PR #9
@bdorfman
Copy link
Contributor

We've added your changes with some refactors in PR #11 commit 43ca6d6

Our contentFrame method method doesn't include spacing FYI so you will probably still want your own helper method for that. Also note that like I said above, all section rects are now full width due to an earlier commit.

@bdorfman bdorfman closed this Apr 13, 2015
@joshfisher
Copy link
Author

Ok, thanks! We're using the section size to snap a draggable panel to a height that shows the first section only, so I think this should work fine for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants