Fix retrieving the root registry key #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #351 +/- ##
==========================================
+ Coverage 70.29% 70.40% +0.11%
==========================================
Files 233 233
Lines 17944 17944
==========================================
+ Hits 12613 12633 +20
+ Misses 5331 5311 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cecinestpasunepipe
requested changes
Aug 9, 2023
| @@ -204,7 +204,7 @@ def root(self) -> KeyCollection: | |||
|
|
|||
| @internal | |||
| @lru_cache(4096) | |||
| def key(self, key: Optional[str] = None) -> KeyCollection: | |||
| def key(self, key: str = "") -> KeyCollection: | |||
There was a problem hiding this comment.
Can you add a regression test for this please?
Poeloe
reviewed
Aug 11, 2023
| @@ -204,7 +204,7 @@ def root(self) -> KeyCollection: | |||
|
|
|||
| @internal | |||
| @lru_cache(4096) | |||
| def key(self, key: Optional[str] = None) -> KeyCollection: | |||
| def key(self, key: str = "") -> KeyCollection: | |||
There was a problem hiding this comment.
Why not use key: Optional[str] = None and use key = key or "" as the first line of the method?
Miauwkeru
force-pushed
the
fix-registry-root
branch
from
04f7af0
to
1627798
Compare
cecinestpasunepipe
approved these changes
Aug 14, 2023
|
LGTM |
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #350