Add Citrix Netscaler OS Plugin #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #357 +/- ##
==========================================
+ Coverage 70.40% 70.55% +0.14%
==========================================
Files 233 234 +1
Lines 17944 18038 +94
==========================================
+ Hits 12633 12726 +93
- Misses 5311 5312 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Miauwkeru
requested changes
Aug 14, 2023
| nstmp_users.add(entry.name) | ||
| for username in self._config_usernames: | ||
| if username == "root" and self.target.fs.exists("/root"): | ||
| yield UnixUserRecord(name="root", home="/root") |
There was a problem hiding this comment.
would you not get a double entry for root in the current way?
Suggested change
| yield UnixUserRecord(name="root", home="/root") | |
| yield UnixUserRecord(name="root", home="/root") | |
| continue |
There was a problem hiding this comment.
If you would like both, add a comment to why you do it it like this ;)
Miauwkeru
reviewed
Aug 14, 2023
Co-authored-by: Miauwkeru <Miauwkeru@users.noreply.github.com>
Fix a typo in my suggestion
Miauwkeru
force-pushed
the
feature/citrix-os-plugin
branch
from
edfa41d
to
8ed1dab
Compare
Miauwkeru
approved these changes
Aug 14, 2023
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds support for Citrix Netscaler images. Depending on which filesystems are available, it maps the filesystems to:
/(the in-memory filesystem loaded by the init binary, whenever this disk is available)/var(Hard disk storage of Citrix Netscalers)/flash(The boot disk, which is mounted to /flash when operating on a live Citrix Netscaler)The plugin parses the configuration files (and, where needed, their backups) to retrieve information about ips, usernames, timezone, version and hostname.
When testing other plugins (such as
os.unix.history.commandhistoryandapps.webserver.apache) I ran into a few peculiarities once the Citrix OS plugin correctly maps directories. For Citrix Netscalers, thecommandhistoryplugin incorrectly parses the bash history of users, and theapacheplugin doesn't process anyhttpaccessorhttperrorlogfiles, which can be useful for investigation. It's probably best to address those fixes in separate PR's.