-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed KeyError when loading Windows targets over SMB #726
Conversation
…ged user credentials
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
=======================================
Coverage 75.01% 75.01%
=======================================
Files 294 294
Lines 25016 25018 +2
=======================================
+ Hits 18766 18768 +2
Misses 6250 6250
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Remove default value Co-authored-by: Miauwkeru <Miauwkeru@users.noreply.github.com>
Co-authored-by: Miauwkeru <Miauwkeru@users.noreply.github.com>
Co-authored-by: Miauwkeru <Miauwkeru@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was asked to make it a bit more explicit with the changes
Co-authored-by: Miauwkeru <Miauwkeru@users.noreply.github.com>
this is in regards with low-privileged user credentials
Change various
["sysvol"]
statements to.get
methods as to avoid breaking SMB targets with low-privileged credentials