Add support for ISO 8601 formatted auth log timestamps #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSCU-CNI
commented
Oct 16, 2024
Schamper
requested changes
Oct 16, 2024
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/refactor-authlog-plugin #901 +/- ##
===================================================================
- Coverage 76.37% 75.70% -0.67%
===================================================================
Files 312 311 -1
Lines 26950 26731 -219
===================================================================
- Hits 20582 20238 -344
- Misses 6368 6493 +125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
requested changes
Oct 16, 2024
Schamper
approved these changes
Oct 16, 2024
Schamper
merged commit 4ec0596
into
fox-it:feature/refactor-authlog-plugin
15 of 18 checks passed
This was referenced Oct 16, 2024
Merged
Miauwkeru
pushed a commit
that referenced
this pull request
Oct 31, 2024
Miauwkeru
pushed a commit
that referenced
this pull request
Oct 31, 2024
Poeloe
pushed a commit
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #860 and introduces support for ISO 8601 formatted timestamps in
auth.logfiles which can (finally 🥳) be found in newer Debian and Ubuntu systems. Fixes #903.