Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build of cramjam a subdependency of fastavro #145

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

pyrco
Copy link
Contributor

@pyrco pyrco commented Oct 1, 2024

No description provided.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.70%. Comparing base (1701dcf) to head (14538e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   83.70%   83.70%           
=======================================
  Files          34       34           
  Lines        3485     3485           
=======================================
  Hits         2917     2917           
  Misses        568      568           
Flag Coverage Δ
unittests 83.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pyrco
Copy link
Contributor Author

pyrco commented Oct 1, 2024

This fixes it for pypy3.9 on Linux. The windows fail seems rather more complicated. We could make that build not required anymore?

Copy link
Member

@yunzheng yunzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sadly doesn't fix the windows pypy3.9. Maybe we should pin cramjam to an older version for now?

@yunzheng
Copy link
Member

yunzheng commented Oct 1, 2024

looks like 3.9 support was removed from cramjam. See milesgranger/cramjam#177

@JSCU-CNI
Copy link
Contributor

JSCU-CNI commented Oct 1, 2024

It seems like pypy3.9 is no longer maintained (or at least distributed) in favor of pypy3.10 since version 7.3.17

We will keep the buildbots building PyPY3.9 until the end of August

https://doc.pypy.org/en/latest/release-v7.3.17.html#pypy-versions-and-speed-pypy-org

@yunzheng
Copy link
Member

yunzheng commented Oct 1, 2024

@pyrco I've pinned cramjam for now for pypy3.9, which seems to be the easiest to do for now.

I think you can also remove the extra deb package now. But i leave that up to you.

@pyrco
Copy link
Contributor Author

pyrco commented Oct 1, 2024

Let's go for the pinning option and see when that fails ;-) If it does there are some other options, which would disable avro support in flow.record on pypy3.9 & windows.

In the meantime we should look into dropping support for pypy3.9. We want to keep CPython 3.9 around for a bit though. The current idea is to stop supporting that once it is out of support upstream.

This reverts commit b821285.

We go for the pinning option
@pyrco pyrco requested a review from yunzheng October 1, 2024 10:18
@yunzheng yunzheng merged commit f6fd02f into main Oct 1, 2024
20 checks passed
@yunzheng yunzheng deleted the fix-cramjam-build branch October 1, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants