-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support file-like objects in record writer #83
Support file-like objects in record writer #83
Conversation
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 79.27% 79.34% +0.06%
==========================================
Files 32 32
Lines 2939 2943 +4
==========================================
+ Hits 2330 2335 +5
+ Misses 609 608 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe open_file()
should actually be called open_path_or_stream()
as it's a wrapper around open_path
and open_stream
.
Do you also know why the test coverage went down so much?
I think the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c909b87
to
4c8518a
Compare
Following #59, this Pull Request adds functionality for adapters of
flow.record
to write to file-like objects.