Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add behaviour to always use datetime.UTC if there is no zoneinfo available #86

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

Miauwkeru
Copy link
Contributor

DIS-2238

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #86 (4a69b7f) into main (2e2eb62) will decrease coverage by 0.05%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   79.27%   79.22%   -0.05%     
==========================================
  Files          32       32              
  Lines        2924     2932       +8     
==========================================
+ Hits         2318     2323       +5     
- Misses        606      609       +3     
Flag Coverage Δ
unittests 79.22% <60.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flow/record/fieldtypes/__init__.py 91.40% <60.00%> (-0.77%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

flow/record/fieldtypes/__init__.py Outdated Show resolved Hide resolved
flow/record/fieldtypes/__init__.py Show resolved Hide resolved
flow/record/fieldtypes/__init__.py Outdated Show resolved Hide resolved
Co-authored-by: Yun Zheng Hu <hu@fox-it.com>
@yunzheng
Copy link
Member

LGTM

@yunzheng yunzheng merged commit ccfa214 into main Oct 11, 2023
26 of 28 checks passed
@yunzheng yunzheng deleted the DIS-2238_add-default-behaviour-if-there-is-no-zoneinfo branch October 11, 2023 07:54
yunzheng added a commit that referenced this pull request Oct 11, 2023
…lable (#86)

Add behaviour to always use datetime.UTC if there is no zoneinfo available

---------

Co-authored-by: Yun Zheng Hu <hu@fox-it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants