-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dist: Update fail2ban filter #221
Conversation
Missing module name prefix sounds like a bug, but quick |
Sure. They look like this:
I can't exactly tell when they're happening. In my log I see IMAP and SMTP Submission failures logged with the correct prefix. |
I think I found it. It seems to happen when using AUTH LOGIN. AUTH PLAINTEXT produces the correct error message. |
Aha, you are right. Logger is not initialized properly for SASL-related code (AUTH PLAIN is handled separately). Regarding this PR, can you adjust regexp to not check prefix at all? I think it is not necessary. P.S. The message was supposed to have prefix |
Amended the commit. The regexp now no longer checks log prefixes. |
Remove unnessecary log prefix matching.
Codecov Report
@@ Coverage Diff @@
## dev #221 +/- ##
==========================================
+ Coverage 50.72% 50.75% +0.03%
==========================================
Files 118 118
Lines 9240 9240
==========================================
+ Hits 4687 4690 +3
+ Misses 4045 4043 -2
+ Partials 508 507 -1
Continue to review full report at Codecov.
|
Thanks! |
Previously the fail2ban regex would only catch failed auth messages with a smtp/submission/lmtp/imap prefix.
This regex now also catches those without such a prefix.
I tested this on my maddy server where it worked well.