Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: default next channel id is inconsistent with other languages #1221

Closed
YXL76 opened this issue Aug 21, 2024 · 3 comments
Closed

rust: default next channel id is inconsistent with other languages #1221

YXL76 opened this issue Aug 21, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@YXL76
Copy link

YXL76 commented Aug 21, 2024

Description

let next_channel_id = self.channels.len() as u16;

void McapWriter::addChannel(Channel& channel) {
channel.id = uint16_t(channels_.size() + 1);
channels_.push_back(channel);
}

channel_id = len(self.__channels) + 1

@YXL76 YXL76 added the bug Something isn't working label Aug 21, 2024
Copy link

linear bot commented Aug 21, 2024

@jtbandes
Copy link
Member

Hi there,
In the future, please follow the issue template when filing issues.

Could you describe why this is causing a problem for you? The MCAP spec does not dictate what the default channel id should be.

@defunctzombie
Copy link
Contributor

Closing for no response. If there's more detail you can provide we are happy to revisit when you do.

@defunctzombie defunctzombie closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants