Fix nested properties not being applied #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nested properties were read and serialized correctly, but on the receiving end, the data would fail to be applied to the synced node because the function `set_value()` in property-entry.gd was using `node.set()` instead of `node.set_indexed()`
|
Nice catch, thanks @jonstvns! Would you mind setting the addon versions to 1.6.1 please? If you're on Linux / WSL, you can run |
|
Nvm, realized I can also push changes 😄 Thanks again @jonstvns and welcome to the club of netfox contributors 😄 |
|
Ahh, sorry, I was traveling and forgot you asked me to bump the version number. thanks for merging, @elementbound |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the netfox synchronizers, nested properties were being read and serialized correctly, but on the receiving end, the data would silently fail to be applied to the synced node because the function
set_value()in property-entry.gd was usingnode.set()instead ofnode.set_indexed()