Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make metrics related components dyn #833

Merged
merged 2 commits into from
Jan 9, 2025
Merged

refactor: make metrics related components dyn #833

merged 2 commits into from
Jan 9, 2025

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Jan 9, 2025

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title. To make things easier.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx added this to the v0.14 milestone Jan 9, 2025
@MrCroxx MrCroxx self-assigned this Jan 9, 2025
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx merged commit 204f84b into main Jan 9, 2025
24 checks passed
@MrCroxx MrCroxx deleted the xx/mdyn branch January 9, 2025 17:38
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 98.55072% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer/src/hybrid/builder.rs 25.00% 3 Missing ⚠️
foyer-bench/src/main.rs 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
foyer-common/src/metrics/mod.rs 100.00% <100.00%> (ø)
foyer-common/src/metrics/model.rs 100.00% <100.00%> (ø)
foyer-common/src/metrics/registry/noop.rs 100.00% <100.00%> (ø)
...-common/src/metrics/registry/opentelemetry_0_26.rs 100.00% <100.00%> (ø)
...-common/src/metrics/registry/opentelemetry_0_27.rs 100.00% <100.00%> (ø)
foyer-common/src/metrics/registry/prometheus.rs 98.38% <100.00%> (+0.06%) ⬆️
...mon/src/metrics/registry/prometheus_client_0_22.rs 100.00% <100.00%> (ø)
foyer-memory/src/cache.rs 82.60% <100.00%> (-0.65%) ⬇️
foyer-storage/src/large/reclaimer.rs 85.48% <100.00%> (ø)
foyer-bench/src/main.rs 64.84% <0.00%> (ø)
... and 1 more

... and 8 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant