Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS build #17

Merged
merged 1 commit into from
Jan 28, 2022
Merged

macOS build #17

merged 1 commit into from
Jan 28, 2022

Conversation

tomstokes
Copy link

Enable compilation on macOS.

@fpagliughi
Copy link
Owner

fpagliughi commented Jan 4, 2022

Hey, thanks for the PR! I was vaguely aware that this would be possible, but didn't realize it would be possible with 5 lines of code! Nice. I have a MacBook somewhere and will pull it out and give it a test.

Ugh. But, of course, now someone will ask if we can do this for Windows as well.

@fpagliughi fpagliughi added this to the v0.4 milestone Jan 4, 2022
@tomstokes
Copy link
Author

Credit to Analog Devices for making libiio cross-platform in the first place. I've been using this crate with IIO on my Mac in a very limited context for a while without issues. Would be good to have some more testing on this, though.

@tomstokes tomstokes changed the base branch from master to develop January 4, 2022 17:34
@fpagliughi
Copy link
Owner

Still haven't found my MacBook. I know it's around here somewhere!
But for now, this doesn't seem to break anything, so I'll merge and give it to the ether for further testing.

@fpagliughi fpagliughi merged commit d7f4a47 into fpagliughi:develop Jan 28, 2022
@tomstokes
Copy link
Author

Thanks for merging. I'm likely the only person using this right now, but I haven't run into any problems yet.

I'll continue testing and submit and PRs if I run into issues.

@fpagliughi
Copy link
Owner

I have an app in production that uses this library. Once I get it updated to this version, a few Mac users will likely start testing it, so we should have some additional feedback in a week or two.

@fpagliughi
Copy link
Owner

@tomstokes I found my MacBook and tried to build. It failed, unable to find the library, and when I looked, my /opt directory was empty. Looking at my homebrew config:

 % brew config | grep HOMEBREW
HOMEBREW_VERSION: 3.3.12
HOMEBREW_PREFIX: /usr/local
...

Looking under there, I found the directory, /usr/local/Frameworks, and when I plugged that in to 'build.rs', it built quite nicely.

So I guess we need a way to find the right directory in the build?

@fpagliughi
Copy link
Owner

fpagliughi commented Jan 31, 2022

I created a new Issue to track the problem.
#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants