Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#54 Use system value for defaultReadBufferSize #55

Merged
merged 1 commit into from
Jan 5, 2020
Merged

#54 Use system value for defaultReadBufferSize #55

merged 1 commit into from
Jan 5, 2020

Conversation

erebe
Copy link
Contributor

@erebe erebe commented Jan 4, 2020 •
edited
Loading

Following our discussion about #54
This PR aims to use as default the value from the host system

snoyberg
snoyberg requested changes Jan 5, 2020
View reviewed changes
Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add a minor version bump and a ChangeLog entry?

@erebe
Copy link
Contributor Author

erebe commented Jan 5, 2020

Done :)

snoyberg
snoyberg approved these changes Jan 5, 2020
View reviewed changes
Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snoyberg snoyberg merged commit a1b69ab into fpco:master Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erebe @snoyberg