-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: add test for cpnp replication #7
e2e: add test for cpnp replication #7
Conversation
05cb1fc
to
c6145fb
Compare
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
c6145fb
to
5547a21
Compare
Very weird - writes succeed and I can see the timestamps/values coming in as expected, and the series is in the WAL but I can't query them :/ something is wrong with the writer but I cannot spot anything wrong so far. |
I added some logging to the writer and I can also see
Maybe something with the timestamp format? |
Also seeing metrics in the ingestor
|
@GiedriusS changing this line from For now we can either remove the unsafe conversion, or we can have a deep copy of labels which re-allocates the name and value strings. |
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Added a |
// NOTE(GiedriusS): do a deep copy because the labels are reused in the capnp message. | ||
// Creation of new series is much rarer compared to adding extra samples | ||
// to an existing series. | ||
for i := range lset { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use lset.Range
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix this on my branch.
14c840f
into
fpetkovski:capnproto-replication
Add e2e test that shows that cpnp replication works. Remove some unused code.