Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pyproject_toml in dependency_getter to poetry #151

Merged

Conversation

mkniewallner
Copy link
Collaborator

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

In prevision of supporting #109, this PR renames pyproject_toml to poetry in dependency_getter, refactoring a bit the methods and tests along the way.

@codecov-commenter
Copy link

Codecov Report

Merging #151 (1a65052) into main (e71dc6a) will decrease coverage by 0.0%.
The diff coverage is 90.0%.

@@           Coverage Diff           @@
##            main    #151     +/-   ##
=======================================
- Coverage   92.2%   92.1%   -0.1%     
=======================================
  Files         42      42             
  Lines       1348    1346      -2     
=======================================
- Hits        1243    1241      -2     
  Misses       105     105             
Impacted Files Coverage Δ
tests/dependency_getter/test_requirements_txt.py 100.0% <ø> (ø)
tests/issue_finders/test_missing.py 100.0% <ø> (ø)
tests/issue_finders/test_obsolete.py 100.0% <ø> (ø)
tests/issue_finders/test_transitive.py 100.0% <ø> (ø)
deptry/core.py 57.1% <33.3%> (ø)
deptry/dependency_getter/poetry.py 100.0% <100.0%> (ø)
tests/dependency_getter/test_poetry.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fpgmaas
Copy link
Owner

fpgmaas commented Oct 2, 2022

Good idea to rename it!

@mkniewallner mkniewallner merged commit 1b12183 into fpgmaas:main Oct 2, 2022
@mkniewallner mkniewallner deleted the rename-pyproject-toml-poetry branch October 2, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants