Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PEP621 with PDM #155

Merged
merged 15 commits into from
Oct 8, 2022
Merged

Add support for PEP621 with PDM #155

merged 15 commits into from
Oct 8, 2022

Conversation

fpgmaas
Copy link
Owner

@fpgmaas fpgmaas commented Oct 3, 2022

This MR adds support for projects that use PDM for their dependency specification, which in turn use PEP621. The reason we add support for PDM and not for PEP621 directly is that PEP621 does not specify a unified way to specify development dependencies, see also the issue #109.

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

@fpgmaas fpgmaas linked an issue Oct 3, 2022 that may be closed by this pull request
@fpgmaas fpgmaas marked this pull request as draft October 3, 2022 08:30
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Merging #155 (025498c) into main (26e55ac) will increase coverage by 0.3%.
The diff coverage is 95.1%.

@@           Coverage Diff           @@
##            main    #155     +/-   ##
=======================================
+ Coverage   94.8%   95.1%   +0.3%     
=======================================
  Files         27      28      +1     
  Lines        808     882     +74     
  Branches     127     133      +6     
=======================================
+ Hits         766     839     +73     
  Misses        28      28             
- Partials      14      15      +1     
Impacted Files Coverage Δ
deptry/core.py 97.2% <75.0%> (+0.1%) ⬆️
deptry/dependency_getter/pdm.py 94.1% <94.1%> (ø)
deptry/dependency_specification_detector.py 100.0% <100.0%> (+5.7%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fpgmaas fpgmaas marked this pull request as ready for review October 3, 2022 18:40
deptry/core.py Outdated Show resolved Hide resolved
deptry/core.py Outdated Show resolved Hide resolved
deptry/dependency_getter/pdm.py Outdated Show resolved Hide resolved
deptry/dependency_getter/pdm.py Outdated Show resolved Hide resolved
deptry/dependency_specification_detector.py Outdated Show resolved Hide resolved
deptry/dependency_specification_detector.py Outdated Show resolved Hide resolved
deptry/core.py Outdated Show resolved Hide resolved
deptry/core.py Outdated Show resolved Hide resolved
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
@fpgmaas
Copy link
Owner Author

fpgmaas commented Oct 6, 2022

Thanks for your feedback @mkniewallner. Accepted and processed all suggestions :)

@fpgmaas fpgmaas merged commit bc461e9 into main Oct 8, 2022
@fpgmaas fpgmaas deleted the 109-pep621 branch October 8, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PEP621 support
3 participants