-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PEP621 with PDM #155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…mDependencyGetter
…mDependencyGetter
Codecov Report
@@ Coverage Diff @@
## main #155 +/- ##
=======================================
+ Coverage 94.8% 95.1% +0.3%
=======================================
Files 27 28 +1
Lines 808 882 +74
Branches 127 133 +6
=======================================
+ Hits 766 839 +73
Misses 28 28
- Partials 14 15 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mkniewallner
reviewed
Oct 5, 2022
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Thanks for your feedback @mkniewallner. Accepted and processed all suggestions :) |
mkniewallner
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds support for projects that use PDM for their dependency specification, which in turn use PEP621. The reason we add support for PDM and not for PEP621 directly is that PEP621 does not specify a unified way to specify development dependencies, see also the issue #109.
PR Checklist
docs
is updatedDescription of changes