Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PEP 621 #166

Merged

Conversation

mkniewallner
Copy link
Collaborator

Resolves #109.

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

Add support for PEP 621 dependency specification. This will ensure that modern package managers that follow PEP 621 are supported.

The implementation makes the assumption that optional dependencies under [project.optional-dependencies] are all non-development ones. In a follow up PR, #162 (comment) could be an interesting option to have to define groups that should be considered development dependencies groups.

Since PDM uses PEP 621 (with an additional logic for development dependencies), this PR also updates its dependency getter class so that it subclasses the PEP 621 one in order to avoid duplication.

The dependency specification detector is also slightly updated so that projects using PDM will only use PDM dependency getter class if they define development dependencies under [tool.pdm.dev-dependencies]. Otherwise, we fallback to PEP 621 dependency getter class, since there is no PDM specifics related to dependencies.

@fpgmaas
Copy link
Owner

fpgmaas commented Nov 2, 2022

I think we could remove the 'Draft' mark from this PR, looks good to me. We can see how we continue with the development dependencies in a new issue.

@mkniewallner mkniewallner marked this pull request as ready for review November 2, 2022 19:47
@mkniewallner mkniewallner force-pushed the feat/handle-pep-621-dependencies branch from 0ec39bf to bc671fd Compare November 6, 2022 12:44
@mkniewallner mkniewallner merged commit f5d4850 into fpgmaas:main Nov 8, 2022
@mkniewallner mkniewallner deleted the feat/handle-pep-621-dependencies branch November 9, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PEP621 support
2 participants