Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add .direnv to default exclude argument #197

Merged
merged 3 commits into from
Nov 15, 2022
Merged

add .direnv to default exclude argument #197

merged 3 commits into from
Nov 15, 2022

Conversation

fpgmaas
Copy link
Owner

@fpgmaas fpgmaas commented Nov 15, 2022 •
edited
Loading

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

@fpgmaas fpgmaas linked an issue Nov 15, 2022 that may be closed by this pull request
Crash when testing a project that has azure libraries installed #169
Closed
mkniewallner
mkniewallner reviewed Nov 15, 2022
View reviewed changes
poetry.lock Outdated Show resolved Hide resolved
@mkniewallner
Copy link
Collaborator

The default list of excludes makes me think that we could benefit from ignoring all files that are in .gitignore, similarly to what black does.

If you think that it makes sense, I'd be happy to create an issue for it.

mkniewallner
mkniewallner reviewed Nov 15, 2022
View reviewed changes
docs/usage.md Outdated Show resolved Hide resolved
@fpgmaas fpgmaas merged commit ad5f767 into main Nov 15, 2022
@fpgmaas fpgmaas deleted the 169-direnv branch November 15, 2022 20:15
@fpgmaas
Copy link
Owner Author

fpgmaas commented Nov 15, 2022

The default list of excludes makes me think that we could benefit from ignoring all files that are in .gitignore, similarly to what black does.

If you think that it makes sense, I'd be happy to create an issue for it.

@mkniewallner That definitely makes sense :) Would have also prevented the related issue from popping up indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkniewallner mkniewallner mkniewallner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when testing a project that has azure libraries installed
2 participants
@fpgmaas @mkniewallner