Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop flake8 to only use ruff #268

Merged
merged 5 commits into from
Jan 9, 2023

Conversation

mkniewallner
Copy link
Collaborator

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

ruff now supports most flake8-simplify rules (astral-sh/ruff#998). Since the last ones will most likely be implemented sooner than later, and all other rules we use for flake8 are implemented, it might be time to fully rely on ruff and drop flake8.

Also taking the occasion to add flake8-builtins rules.

@codecov-commenter
Copy link

Codecov Report

Merging #268 (6477e52) into main (0993fc0) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #268     +/-   ##
=======================================
- Coverage   95.7%   95.7%   -0.1%     
=======================================
  Files         32      32             
  Lines        922     920      -2     
  Branches     193     192      -1     
=======================================
- Hits         883     881      -2     
  Misses        26      26             
  Partials      13      13             
Impacted Files Coverage Δ
deptry/imports/extract.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mkniewallner mkniewallner marked this pull request as ready for review January 8, 2023 15:35
@mkniewallner mkniewallner merged commit 69eb238 into fpgmaas:main Jan 9, 2023
@mkniewallner mkniewallner mentioned this pull request Jan 24, 2023
@mkniewallner mkniewallner deleted the chore/drop-flake8 branch January 29, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants