-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use more ruff
rules and replace pyupgrade
and pygrep-hooks
usages
#276
chore: use more ruff
rules and replace pyupgrade
and pygrep-hooks
usages
#276
Conversation
It is now already passed in the pre-commit configuration: https://github.com/charliermarsh/ruff-pre-commit/blob/v0.0.230/.pre-commit-hooks.yaml#L4.
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
=======================================
- Coverage 95.7% 95.7% -0.1%
=======================================
Files 32 32
Lines 918 915 -3
Branches 191 191
=======================================
- Hits 879 876 -3
Misses 26 26
Partials 13 13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
# Respect `exclude` and `extend-exclude` settings. | ||
args: ["--force-exclude"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--force-exclude
is now included by default in the pre-commit configuration, so we can remove it.
PR Checklist
docs
is updatedDescription of changes
Use
ruff
to replacepyupgrade
(almost all rules are implemented) andpygrep-hooks
(the only rule we use is implemented, the other are either nice to have, or should not cause any harm).Also enable more rules that would be nice to have in the codebase, but feel free to tell me if you disagree with some: