Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with DEP004 being raised incorrectly #376

Merged
merged 4 commits into from
May 9, 2023
Merged

Conversation

fpgmaas
Copy link
Owner

@fpgmaas fpgmaas commented May 9, 2023

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #376 (933a696) into main (54cb1c3) will not change coverage.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #376   +/-   ##
=====================================
  Coverage   96.6%   96.6%           
=====================================
  Files         37      37           
  Lines       1040    1040           
  Branches     207     207           
=====================================
  Hits        1005    1005           
  Misses        22      22           
  Partials      13      13           
Impacted Files Coverage Δ
deptry/issues_finder/misplaced_dev.py 89.1% <100.0%> (ø)

@fpgmaas fpgmaas merged commit b5102b1 into main May 9, 2023
@fpgmaas fpgmaas deleted the fix/misplaced-dev branch May 9, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deptry should allow to install extras of a dependency as dev-dependencies
2 participants