fix(python_file_finder): load gitignore from where CLI is invoked #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docs
is updatedDescription of changes
.gitignore
is currently looked for based on the root directory passed as a CLI argument. This means that developers using asrc
directory and invokingdeptry
withdeptry src
won't benefit from gitignore being loaded.I don't think that there are a lot of use cases where
.gitignore
would be located in a different directory that the onedeptry
is launched from, so this PR updates the behaviour so that.gitignore
is always loaded based on wheredeptry
is invoked.If there really is a need for explicitly configuring the path to
.gitignore
, we can think about adding an option later.Note that this PR will also facilitate the implementation of #381, even if doesn't strictly requires it, since we could also loop over each directory passed through the CLI.