Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(poetry): consider all groups for dev dependencies #392

Conversation

mkniewallner
Copy link
Collaborator

Resolves #391.

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

Update Poetry dependencies parsing logic to consider dependencies from all groups as development dependencies.

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #392 (c0ef553) into main (133a9cc) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #392   +/-   ##
=====================================
  Coverage   96.1%   96.1%           
=====================================
  Files         38      38           
  Lines       1067    1072    +5     
  Branches     214     215    +1     
=====================================
+ Hits        1026    1031    +5     
  Misses        25      25           
  Partials      16      16           
Impacted Files Coverage Δ
deptry/dependency_getter/poetry.py 100.0% <100.0%> (ø)

@mkniewallner mkniewallner marked this pull request as ready for review May 10, 2023 19:54
@mkniewallner mkniewallner requested a review from fpgmaas May 10, 2023 19:54
@mkniewallner mkniewallner merged commit a10ef26 into fpgmaas:main May 11, 2023
@mkniewallner mkniewallner deleted the feat/parse-all-groups-dev-dependencies-poetry branch May 11, 2023 09:01
@fpgmaas fpgmaas mentioned this pull request Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve development dependencies from all dependencies groups in Poetry
2 participants