-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement import extraction for notebooks in Rust #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
=======================================
- Coverage 90.7% 90.6% -0.2%
=======================================
Files 38 35 -3
Lines 1086 1011 -75
Branches 224 205 -19
=======================================
- Hits 986 916 -70
+ Misses 85 81 -4
+ Partials 15 14 -1 ☔ View full report in Codecov by Sentry. |
mkniewallner
approved these changes
Mar 18, 2024
mkniewallner
added a commit
to mkniewallner/deptry
that referenced
this pull request
Mar 24, 2024
Obsolete since fpgmaas#606.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docs
is updatedDescription of changes
.py
files in Rust, and.ipynb
files in Python. This moves the functionality foripynb
files to Rust too.src/imports
directory, with shared functionality inshared.rs
get_imports_from_py_file
since it was not used.