fix(violations): show module name for DEP003 #644
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #643.
PR Checklist
docs
is updatedDescription of changes
We currently show the package name for DEP003, but ignore rules take the Python module name into account for DEP003, not the package name. So this PR updates the report to show the Python module name instead.
We might want to consider switching to the package name for the ignore rule, and show the package name in the report as well, but this would technically be a breaking change for users that already define ignore rules and use the Python module name, so I'd prefer to go with this fix for now.