Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for requirements.txt #84

Merged
merged 4 commits into from
Sep 11, 2022
Merged

Added support for requirements.txt #84

merged 4 commits into from
Sep 11, 2022

Conversation

fpgmaas
Copy link
Owner

@fpgmaas fpgmaas commented Sep 10, 2022

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

  • Added functionality to check which dependency specification format is used (pyproject.toml vs requirements.txt)
  • Added a requirements.txt parser

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2022

Codecov Report

Merging #84 (3256631) into develop (78884bf) will increase coverage by 2.1%.
The diff coverage is 96.9%.

@@            Coverage Diff            @@
##           develop     #84     +/-   ##
=========================================
+ Coverage     92.6%   94.7%   +2.1%     
=========================================
  Files           24      28      +4     
  Lines          718     973    +255     
=========================================
+ Hits           665     922    +257     
+ Misses          53      51      -2     
Impacted Files Coverage Δ
deptry/cli_defaults.py 100.0% <ø> (ø)
deptry/dependency.py 97.6% <ø> (ø)
deptry/config.py 96.3% <86.3%> (-3.7%) ⬇️
deptry/dependency_specification_detector.py 88.5% <88.5%> (ø)
deptry/dependency_getter/requirements_txt.py 98.5% <98.5%> (ø)
deptry/dependency_getter/pyproject_toml.py 96.0% <100.0%> (ø)
deptry/python_file_finder.py 100.0% <100.0%> (ø)
tests/test_cli.py 100.0% <100.0%> (ø)
tests/test_config.py 100.0% <100.0%> (ø)
tests/test_dependency_specification_detector.py 100.0% <100.0%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fpgmaas fpgmaas merged commit 4388158 into develop Sep 11, 2022
@fpgmaas fpgmaas deleted the pip branch September 11, 2022 13:34
fpgmaas pushed a commit that referenced this pull request Sep 11, 2022
* Added support for requirements.txt (#84)
* Solved bug with relative imports being marked as missing (#86)
fpgmaas added a commit that referenced this pull request Oct 2, 2022
* Added support for requirements.txt (#84)
* Solved bug with relative imports being marked as missing (#86)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we add support for other dependency specifications than pyproject.toml, such as requirements.txt?
2 participants