Replace the node-static package with serve-handler
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that node-static module hasn't been updated for 6 years and it has some vulnerabilities. On the other and serve-handler is the core package of `serve`, which is maintained by vercel. So it looks like it's a safer option. There were more options to choose from, but that looks like a good option, and required less effort to migrate.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that node-static module hasn't been updated for 6 years and it has some vulnerabilities. On the other and serve-handler is the core package of
serve, which is maintained by vercel. So it looks like it's a safer option. There were more options to choose from, but that looks like a good option, and required less effort to migrate.Note that this came from here: sitespeedio/sitespeed.io#4330