Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If keeping connection alive, alow for ONE failure, in that case, it will turn off keep alive and work as if there is no keep alive capability. It seems some internet providers do not like how much time a MSX can take from the last packet of GET transfer until it send again a new information on the opened connection and close the connection themselves (this is not cool, but hey, that's life)
A fix for packages that might leave some files on a folder before MSX HUB interprets it should delete a folder, there was a scenario / package for that where a folder would remain after uninstalling, I just don't remember which one, but this has been fixed and should work if up to 5 folders occurrences like this (I've seen just 1)
Pre-allocate entire file if size is known: On a large FAT16 partition that is nearly full this can save a lot of time, this avoids Nextor having to calculate clusters every few blocks written, it will do just once... That is useful until Nestor release a new version of Nextor that uses a different cluster approach
P.s.: As I believe you are going to review and test HUB on your end, I've decided to implement and test the keep-alive fix first on HUB, I should finish the same work on HUBG soon then I'll share with you the link to the HUBG package containing the fix as well
P.s.2: As I do not have this issue here, the only way I found to test the fix was to test it on BlueMSX, so I could put a breakpoint on the http_send function just after the first file of a package starts transferring, then when the breakpoint was hit, I've just wait a few minutes before running the code again, which resulted on the failure of trying to send http on the keep alive connection and then a retry opening the connection. Also could verify that the connection was no long being kept alive after the first failure, so seemed to work fine :)