Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hub 1.5 #14

Merged
merged 2 commits into from
Sep 19, 2020
Merged

Hub 1.5 #14

merged 2 commits into from
Sep 19, 2020

Conversation

ducasp
Copy link
Contributor

@ducasp ducasp commented Sep 15, 2020

  • If keeping connection alive, alow for ONE failure, in that case, it will turn off keep alive and work as if there is no keep alive capability. It seems some internet providers do not like how much time a MSX can take from the last packet of GET transfer until it send again a new information on the opened connection and close the connection themselves (this is not cool, but hey, that's life)

  • A fix for packages that might leave some files on a folder before MSX HUB interprets it should delete a folder, there was a scenario / package for that where a folder would remain after uninstalling, I just don't remember which one, but this has been fixed and should work if up to 5 folders occurrences like this (I've seen just 1)

  • Pre-allocate entire file if size is known: On a large FAT16 partition that is nearly full this can save a lot of time, this avoids Nextor having to calculate clusters every few blocks written, it will do just once... That is useful until Nestor release a new version of Nextor that uses a different cluster approach

P.s.: As I believe you are going to review and test HUB on your end, I've decided to implement and test the keep-alive fix first on HUB, I should finish the same work on HUBG soon then I'll share with you the link to the HUBG package containing the fix as well

P.s.2: As I do not have this issue here, the only way I found to test the fix was to test it on BlueMSX, so I could put a breakpoint on the http_send function just after the first file of a package starts transferring, then when the breakpoint was hit, I've just wait a few minutes before running the code again, which resulted on the failure of trying to send http on the keep alive connection and then a retry opening the connection. Also could verify that the connection was no long being kept alive after the first failure, so seemed to work fine :)

ducasp and others added 2 commits April 23, 2020 19:11
- If keeping connection alive, alow for ONE failure, in that case, it will turn off keep alive and work as if there is no keep alive capability. It seems some internet providers do not like how much time a MSX can take from the last packet of GET transfer until it send again a new information on the opened connection and close the connection themselves (this is not cool, but hey, that's life)

- A fix for packages that might leave some files on a folder before MSX HUB interprets it should delete a folder, there was a scenario / package for that where a folder would remain after uninstalling, I just don't remember which one, but this has been fixed and should work if up to 5 folders occurrences like this (I've seen just 1)

- Pre-allocate entire file if size is known: On a large FAT16 partition that is nearly full this can save a lot of time, this avoids Nextor having to calculate clusters every few blocks written, it will do just once... That is useful until Nestor release a new version of Nextor that uses a different cluster approach
@ducasp
Copy link
Contributor Author

ducasp commented Sep 16, 2020

Hi Fr3nd, I've update HUBG to version 0.80, the set of fixes is the same, the new package is:

https://github.com/ducasp/MSX-Development/raw/2e17f811169341642c131a8962caaad563fa122a/UNAPI/HUBG/BINARY_PACK/HUBG.zip

Let me know if you find any issues with HUB or HUBG new versions.

Thanks!

@fr3nd
Copy link
Owner

fr3nd commented Sep 16, 2020

Thank you! I'm currently away and cannot test it. I'll do it as soon as possible

@ducasp
Copy link
Contributor Author

ducasp commented Sep 16, 2020

No Rush, take any time you need :)

@fr3nd fr3nd merged commit b1f6609 into fr3nd:master Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants