Speed up transfers #6
Conversation
Speed it up it a lot, from 2,7KB/s to 20KB/s!!! It will speed it up due to three factors: - when waiting for tcp data, do not wait an extra tick change, TCPIP_WAIT call will wait any time it needs, no need for additional wait. - changed a little bit the progress bar presentation so it is not printed every received block almost one line of data, VDP text writes on DOS are dead slow... Instead, change it to update only adding the => when enough data to move the counter arrived. Also made the calculation to progress the bar a lot easier for z80 using only one division when initializing the progress bar and then only adds received size to a block counter, if it exceeds the block, progress the bar. - Changed the way of dealing with received data -> file... Instead of moving byte per byte on multiple function calls (stacking and unstacking is not efficient, and moving the memory back and forth byte per byte is not efficient as well), just move the whole received data block to the file, directly from the RCV call. I've tested it for quite a few files, and it is way faster on my UNAPI adapter.
|
Thank you!! It looks promising. I'm currently unable to review your contribution, but I'll do it as soon as possible! |
…han the progress bar size in characters is received
|
Hi fr3nd, I have made a small fix, where some hub packages were not working on my improved speed version of MSX HUB because it would loop filling the screen with the progress bar when a file with too small size was received (i.e.: sofarun has a bas file of 27 bytes and trying to hub install it in 80 columns would not be succesfull). This version seems to be quite stable and I've tested it with many packages with success. :) |
|
Wow, that's a huge improvement. The speed increase is really noticeable and so far I haven't detected any issue. I'd like to do some more testing before merging your PR and releasing a new version, but it looks really good! Thank you for your contribution! |
|
I did some small and cosmetic changes to your code in #9 and I merged it. Awesome work, thank you! 🥇 |
|
Glad to help! 🙂 |
Hi fr3nd,
I've made a few changes that speed up a lot file transfers. On my UNAPI adapter, it went from 2,7KB/s average to almost 20KB/s average.
Best regards,
Oduvaldo