Merge pull request #1748 from fractal-analytics-platform/1741-drop-tr…

…yexcept-for-integrityerror-in-first-user-creation

Drop try/except for IntegrityError in first-user creation

CHANGELOG.md

@@ -3,7 +3,7 @@
 # 2.4.0
 
 * App:
-    * Move creation of first user from application startup into `fractalctl set-db` command (\#1738).
+    * Move creation of first user from application startup into `fractalctl set-db` command (\#1738, \#1748).
     * Add creation of default user group into `fractalctl set-db` command (\#1738).
     * Create `update-db-script` for current version, that adds all users to default group (\#1738).
 * API:

fractal_server/app/security/__init__.py

@@ -43,7 +43,6 @@
 from fastapi_users.models import ID
 from fastapi_users.models import OAP
 from fastapi_users.models import UP
-from sqlalchemy.exc import IntegrityError
 from sqlalchemy.ext.asyncio import AsyncSession
 from sqlalchemy.orm import selectinload
 from sqlmodel import func
@@ -295,12 +294,6 @@ async def _create_first_user(
                     user = await user_manager.create(UserCreate(**kwargs))
                     logger.info(f"User {user.email} created")
 
-    except IntegrityError:
-        logger.warning(
-            f"Creation of user {email} failed with IntegrityError "
-            "(likely due to concurrent attempts from different workers)."
-        )
-
     except UserAlreadyExists:
         logger.warning(f"User {email} already exists")