avoit drop_constraint in sqlite

fractal-analytics-platform · Sep 9, 2024 · def9f1c · def9f1c
1 parent 905cb95
commit def9f1c
Showing 1 changed file with 13 additions and 31 deletions.
diff --git a/...2_remove_link_between_v1_and_v2_tasks_.py → ...2_remove_link_between_v1_and_v2_tasks_.py b/...2_remove_link_between_v1_and_v2_tasks_.py → ...2_remove_link_between_v1_and_v2_tasks_.py
@@ -1,56 +1,38 @@
 """Remove link between v1 and v2 tasks/workflowtasks tables
 
-Revision ID: 9e081c49e542
+Revision ID: 820d66a50cc2
 Revises: 5bf02391cfef
-Create Date: 2024-09-04 08:44:12.471028
+Create Date: 2024-09-09 11:21:59.311683
 
 """
 import sqlalchemy as sa
 from alembic import op
+from sqlalchemy.dialects import sqlite
+
 
 # revision identifiers, used by Alembic.
-revision = "9e081c49e542"
+revision = "820d66a50cc2"
 down_revision = "5bf02391cfef"
 branch_labels = None
 depends_on = None
 
 
 def upgrade() -> None:
-
-    # We modified the auto generated commands because sqlite does not support
-    # "alter table". They would have worked fine with postgresql.
-
     # ### commands auto generated by Alembic - please adjust! ###
-    # op.drop_column("task", "is_v2_compatible")
-    # op.alter_column(
-    #     "workflowtaskv2",
-    #     "task_id",
-    #     existing_type=sa.INTEGER(),
-    #     nullable=False,
-    # )
-    # op.drop_constraint(
-    #     "fk_workflowtaskv2_task_legacy_id_task",
-    #     "workflowtaskv2",
-    #     type_="foreignkey",
-    # )
-    # op.drop_column("workflowtaskv2", "task_legacy_id")
-    # op.drop_column("workflowtaskv2", "is_legacy_task")
-    # ### end Alembic commands ###
-
-    with op.batch_alter_table("task", schema=None) as batch_op:
-        batch_op.drop_column("is_v2_compatible")
-
-    with op.batch_alter_table("workflowtaskv2", schema=None) as batch_op:
-        batch_op.drop_constraint(
-            "fk_workflowtaskv2_task_legacy_id_task", type_="foreignkey"
-        )
-
+    op.drop_column("task", "is_v2_compatible")
     with op.batch_alter_table("workflowtaskv2", schema=None) as batch_op:
         batch_op.alter_column(
             "task_id", existing_type=sa.INTEGER(), nullable=False
         )
         batch_op.drop_column("task_legacy_id")
         batch_op.drop_column("is_legacy_task")
+    if not isinstance(op.get_bind().dialect, sqlite.dialect):
+        op.drop_constraint(
+            "fk_workflowtaskv2_task_legacy_id_task",
+            "workflowtaskv2",
+            type_="foreignkey",
+        )
+    # ### end Alembic commands ###
 
 
 def downgrade() -> None: