Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user_id as monitoring query parameter #1009

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Nov 21, 2023

closes #978

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md

Copy link

github-actions bot commented Nov 21, 2023

Coverage report

The coverage rate went from 93.15% to 93.18% ⬆️
The branch rate is 84%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

fractal_server/app/routes/api/v1/_aux_functions.py

100% of new lines are covered (100% of the complete file).

fractal_server/app/routes/api/v1/task.py

100% of new lines are covered (94.16% of the complete file).

fractal_server/app/routes/monitoring.py

100% of new lines are covered (97.22% of the complete file).

@tcompa tcompa self-requested a review November 22, 2023 09:04
@tcompa
Copy link
Collaborator

tcompa commented Nov 23, 2023

CI fails for known reasons (ref #954). Merging.

@tcompa tcompa merged commit 2f35a24 into main Nov 23, 2023
6 of 8 checks passed
@tcompa tcompa deleted the 978-add-user_id-to-query-parameters-of-jobdatasetworkflow-monitoring-endpoints branch November 23, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user_id to query parameters of job/dataset/workflow monitoring endpoints
2 participants