Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tasks-collection fixtures #1637

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Jul 11, 2024

closes #1622

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I merged main into the current branch.

@ychiucco ychiucco added the testing testing label Jul 11, 2024
Copy link

github-actions bot commented Jul 11, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.8 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.4 8.6 0.98 0.7 0.7
power 438.3 421.2 1.04 440.2 440.2
dataset 172.2 162.7 1.06 171.2 171.2
project 51.1 50.0 1.02 58.9 58.9
job 29.0 28.8 1.01 41.7 41.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.2 6.0 1.03 2.2 2.2
power 141.5 139.6 1.01 652.0 652.0
dataset 145.2 139.6 1.04 904.8 904.8
project 46.7 46.2 1.01 283.7 283.7
job 39.9 39.0 1.02 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.1 7.2 0.85 0.1 0.1
power 6.0 6.0 1.00 0.1 0.1
dataset 6.0 6.0 1.00 0.1 0.1
project 8.1 7.8 1.04 2.3 2.3
job 6.1 6.0 1.02 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 13.0 12.8 1.02 0.8 0.8
power 25.0 24.4 1.02 29.8 29.8
dataset 19.3 18.8 1.03 17.1 17.1
project 21.9 21.8 1.00 21.5 21.5
job 10.3 10.3 1.00 0.9 0.9

POST /api/v2/project/3/dataset/402/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 156.2 151.2 1.03 275.1 275.1

Copy link

github-actions bot commented Jul 11, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@tcompa tcompa self-requested a review July 15, 2024 08:59
tests/fixtures_tasks_v2.py Outdated Show resolved Hide resolved
tests/fixtures_tasks_v2.py Outdated Show resolved Hide resolved
@ychiucco ychiucco requested a review from tcompa July 16, 2024 07:26
tests/fixtures_tasks_v2.py Outdated Show resolved Hide resolved
tests/fixtures_tasks_v2.py Outdated Show resolved Hide resolved
tests/fixtures_tasks_v2.py Outdated Show resolved Hide resolved
tests/fixtures_tasks_v2.py Outdated Show resolved Hide resolved
tests/fixtures_tasks_v2.py Outdated Show resolved Hide resolved
tests/fixtures_tasks_v2.py Outdated Show resolved Hide resolved
…rized-task-collection-to-simplify-task-collection-in-tests' into 1622-use-new-modularized-task-collection-to-simplify-task-collection-in-tests
@tcompa tcompa merged commit 21e92ca into main Jul 17, 2024
@tcompa tcompa deleted the 1622-use-new-modularized-task-collection-to-simplify-task-collection-in-tests branch July 17, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new modularized task collection to simplify task collection in tests
2 participants