Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sqlmodel #1674

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Bump sqlmodel #1674

merged 3 commits into from
Jul 25, 2024

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Jul 23, 2024

closes #1673

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue Jul 23, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 23, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.9 0.8 1.12 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.5 8.3 1.02 0.7 0.7
power 416.8 415.9 1.00 440.2 440.2
dataset 164.1 158.0 1.04 171.2 171.2
project 47.0 47.5 0.99 58.9 58.9
job 30.7 27.3 1.12 41.7 41.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.8 5.7 1.02 2.2 2.2
power 139.2 134.0 1.04 652.0 652.0
dataset 140.0 139.3 1.01 904.8 904.8
project 47.5 45.8 1.04 283.7 283.7
job 37.0 37.7 0.98 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.2 6.1 1.02 0.1 0.1
power 6.0 5.8 1.03 0.1 0.1
dataset 6.1 5.8 1.05 0.1 0.1
project 7.9 7.9 1.00 2.3 2.3
job 6.0 5.8 1.03 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.4 10.0 1.04 0.8 0.8
power 24.0 23.6 1.02 29.8 29.8
dataset 18.7 20.4 0.92 17.1 17.1
project 21.8 20.8 1.05 21.5 21.5
job 13.7 9.9 1.38 0.9 0.9

POST /api/v2/project/3/dataset/402/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 149.4 148.5 1.01 275.1 275.1

Copy link

github-actions bot commented Jul 23, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa merged commit 3478d3d into main Jul 25, 2024
19 checks passed
@tcompa tcompa deleted the 1673-bump-sqlmodel branch July 25, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump sqlmodel
2 participants