Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict to pip<24.1 #1675

Merged
merged 12 commits into from
Jul 25, 2024
Merged

Restrict to pip<24.1 #1675

merged 12 commits into from
Jul 25, 2024

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Jul 23, 2024

closes #1591

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue Jul 23, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 23, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.9 1.0 0.90 0.0 0.0
power 0.8 1.0 0.80 0.0 0.0
dataset 0.8 1.0 0.80 0.0 0.0
project 0.9 1.0 0.90 0.0 0.0
job 0.8 1.0 0.80 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.5 12.1 0.87 0.7 0.7
power 441.5 466.3 0.95 440.2 440.2
dataset 175.6 184.5 0.95 171.2 171.2
project 50.4 63.1 0.80 58.9 58.9
job 34.9 33.8 1.03 41.7 41.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.7 8.9 0.75 2.2 2.2
power 145.0 147.9 0.98 652.0 652.0
dataset 145.7 146.6 0.99 904.8 904.8
project 50.8 47.7 1.06 283.7 283.7
job 41.6 36.1 1.15 224.8 224.8

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.5 6.0 1.25 0.1 0.1
power 7.9 5.8 1.36 0.1 0.1
dataset 7.8 5.9 1.32 0.1 0.1
project 9.1 8.0 1.14 2.3 2.3
job 6.9 5.9 1.17 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 12.0 10.3 1.17 0.8 0.8
power 26.0 25.8 1.01 29.8 29.8
dataset 21.0 18.0 1.17 17.1 17.1
project 24.3 22.5 1.08 21.5 21.5
job 15.7 11.1 1.41 0.9 0.9

POST /api/v2/project/3/dataset/402/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 158.9 153.3 1.04 275.1 275.1

Copy link

github-actions bot commented Jul 23, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server
  config.py
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
  fractal_server/tasks/v2
  _venv_pip.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa
Copy link
Collaborator

tcompa commented Jul 25, 2024

Let's modify one of the task collection tests, setting the max version e.g. to 23 and adding an assertion on the pip version.
Note that an easy way to do this is to access collection_state.data["freeze"] and look for the pip=... entry.

@tcompa tcompa merged commit 7b0fae9 into main Jul 25, 2024
20 checks passed
@tcompa tcompa deleted the 1591-pin-task-collection-pip-to-241 branch July 25, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin task-collection pip to <24.1?
2 participants