Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review SLURM configuration and include new configuration option for pre-sbatch commands and gpus #1678

Merged
merged 32 commits into from
Jul 24, 2024
Merged

Review SLURM configuration and include new configuration option for pre-sbatch commands and gpus #1678

merged 32 commits into from
Jul 24, 2024

Commits on Jul 23, 2024

  1. Fix f-string in log

    @tcompa
    tcompa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5b2d25b View commit details
    Browse the repository at this point in the history

  2. Improve check of gpu_slurm_config=None

    @tcompa
    tcompa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8d8d9bf View commit details
    Browse the repository at this point in the history

  3. Merge ssh/non-ssh redundant copies of get_slurm_config.py

    @tcompa
    tcompa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1d59771 View commit details
    Browse the repository at this point in the history

  4. Rename v1 test

    @tcompa
    tcompa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    57a2977 View commit details
    Browse the repository at this point in the history

  5. Move get_slurm_config module to v2 scope

    @tcompa
    tcompa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d0466d4 View commit details
    Browse the repository at this point in the history

  6. Remove obsolete directory arguments from get_slurm_config in v2

    @tcompa
    tcompa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    779e2d3 View commit details
    Browse the repository at this point in the history

  7. Fix typo in tests (paralell->parallel)

    @tcompa
    tcompa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c3672dd View commit details
    Browse the repository at this point in the history

  8. Remove obsolete argument from get_slurm_config call

    @tcompa
    tcompa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1774d88 View commit details
    Browse the repository at this point in the history

  9. Add test_slurm_config for v2

    @tcompa
    tcompa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c4cecb5 View commit details
    Browse the repository at this point in the history

  10. Rename app.runner.v2._slurm into app.runner.v2._slurm_sudo

    @tcompa
    tcompa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    060680e View commit details
    Browse the repository at this point in the history

  11. Rename app.runner.v2._slurm into app.runner.v2._slurm_sudo

    @tcompa
    tcompa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    08ec232 View commit details
    Browse the repository at this point in the history

  12. Add init file for _slurm_common subpackage

    @tcompa
    tcompa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8879240 View commit details
    Browse the repository at this point in the history

  13. Simplify conditional check in slurm config

    @tcompa
    tcompa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    baafe51 View commit details
    Browse the repository at this point in the history

  14. Include pre_submission_commands in slurm config models

    @tcompa
    tcompa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    3bf72b1 View commit details
    Browse the repository at this point in the history

  15. Include logic for pre-submission commands in ssh executor (ref #1565)

    @tcompa
    tcompa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b819297 View commit details
    Browse the repository at this point in the history

  16. Add test_slurm_ssh_executor_submit_with_pre_sbatch

    @tcompa
    tcompa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    cbbbd70 View commit details
    Browse the repository at this point in the history

  17. Add test_run_command_session_persistence

    @tcompa
    tcompa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5d0e6c3 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Use pre_submission_commands attribute name consistently

    @tcompa
    tcompa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    9da7006 View commit details
    Browse the repository at this point in the history

  2. Include SLURM gpus parameter (ref #1679)

    @tcompa
    tcompa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    69998d5 View commit details
    Browse the repository at this point in the history

  3. Fix behvior for needs_gpu=False in slurm-config

    @tcompa
    tcompa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    00da10b View commit details
    Browse the repository at this point in the history

  4. Add test_get_slurm_config_gpu_options

    @tcompa
    tcompa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    7621d83 View commit details
    Browse the repository at this point in the history

  5. Print warning when using pre_submission_commands in non-SSH SLURM e… 

    …xecutor
    @tcompa
    tcompa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    320f1a9 View commit details
    Browse the repository at this point in the history

  6. Introduce FractalSSH.write_remote_file

    @tcompa
    tcompa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a3d698f View commit details
    Browse the repository at this point in the history

  7. Introduce test for FractalSSH.write_remote_file

    @tcompa
    tcompa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c29d5e6 View commit details
    Browse the repository at this point in the history

  8. Rename variable in fixture

    @tcompa
    tcompa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4999de3 View commit details
    Browse the repository at this point in the history

  9. Simplify error message

    @tcompa
    tcompa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    e9f0e3f View commit details
    Browse the repository at this point in the history

  10. Fix comment

    @tcompa
    tcompa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    37ebade View commit details
    Browse the repository at this point in the history

  11. Update CHANGELOG [skip ci]

    @tcompa
    tcompa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    168ccb8 View commit details
    Browse the repository at this point in the history

  12. Fix comment [skip ci]

    @tcompa
    tcompa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6a117c1 View commit details
    Browse the repository at this point in the history

  13. Update CHANGELOG [skip ci]

    @tcompa
    tcompa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    bda4cd0 View commit details
    Browse the repository at this point in the history

  14. Drop obsolete test

    @tcompa
    tcompa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    fc467b9 View commit details
    Browse the repository at this point in the history

  15. Cover additional branch in write_remote_file method test

    @tcompa
    tcompa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    de4b037 View commit details
    Browse the repository at this point in the history